Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)

ios/MullvadREST/Relay/RelaySelector.swift line 157 at r1 (raw file):

                return true
            case let .only(relayConstraint):
                // At least one location must match the relay under test.

There's a lot of logic in this loop; wouldn't it make sense to move it to RelayLocation, perhaps a RelayWithLocation.matches(Location) method or similar?

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acb-mv)

ios/MullvadREST/Relay/RelaySelector.swift line 157 at r1 (raw file):

Yeah, that's a good idea I think. I 'll look at it 👍

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acb-mv)

ios/MullvadREST/Relay/RelaySelector.swift line 157 at r1 (raw file):

Can you create a test case that fails with the previous version, and is fixed by the changes here ?

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acb-mv)

ios/MullvadREST/Relay/RelaySelector.swift line 157 at r1 (raw file):

Sure thing.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acb-mv)

ios/MullvadREST/Relay/RelaySelector.swift line 157 at r1 (raw file):

In order to create such a test I need to make this function internal rather than private. I can't rely on on testing evaluate above, since the result will be random each time.

Reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @acb-mv)

Reviewed 1 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion